Merged
Conversation
SteveL-MSFT
reviewed
Mar 11, 2021
SteveL-MSFT
reviewed
Mar 11, 2021
SteveL-MSFT
reviewed
Mar 12, 2021
SteveL-MSFT
reviewed
Mar 12, 2021
SteveL-MSFT
approved these changes
Mar 12, 2021
anamnavi
reviewed
Mar 12, 2021
Member
|
LGTM, thanks for adding me to this PR! It was helpful to see Reset-Store (and I'll look further into that for PSGet as we discussed) and |
anamnavi
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes to the following:
Remove the
-Forceparameter fromSet-SecretStoreConfigurationcmdlet. The-Confirm:$falseparameter should now be used to prevent PowerShell from prompting for confirmation.Add
-Passwordparameter toSet-SecretStoreConfigurationcmdlet. This new parameter allows a password to be passed in as a cmdlet argument so that prompting is not needed.Fix the manifest license Url.
Update and fix help files. Help files were not compiling into xml correctly before.